fix(optimizer): don't externalize transitive dep package name with asset extension#18152
Merged
patak-dev merged 4 commits intovitejs:mainfrom Oct 7, 2024
Merged
Conversation
|
|
hi-ogawa
commented
Sep 20, 2024
sapphi-red
added
p3-minor-bug
sapphi-red
approved these changes
Sep 26, 2024
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress |
Contributor
Author
|
/ecosystem-ci run sveltekit |
Contributor
Author
|
I reran sveltekit and CI passed, so it was probably a flake. |
7 tasks
moonlitusun
pushed a commit
to moonlitusun/vite
that referenced
this pull request
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#16242 handled the case of
requirecall, but it looks like it should coverimportas well. This was suggested in #16242 (comment) and probably this is indeed necessary to handle external package name likeimport "some-package.pdf".