test(v6): add runner dynamic import test#17422
Closed
hi-ogawa wants to merge 4 commits into
Closed
Conversation
|
|
sheremet-va
reviewed
Jun 10, 2024
This was referenced Jul 19, 2024
Member
|
This does seem consistent with how Vite works: Vite server expects the URL, but instead, you pass down the full path. The server says that this module doesn't exist: environment.moduleGraph.getModuleByUrl('/src/basic.js') // exists
environment.moduleGraph.getModuleByUrl('<root>/src/basic.js') // doesn't existThere is an inconsistency when you call It does seem more like a bug because in Node.js this code will work correctly 🤔 |
Member
|
Should be fixed by |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm testing alpha.18 hi-ogawa/vite-environment-examples#91 and found that
import(/* @vite-ignore */ someAboslutePath)is returning a duplicate module. I added a failing test case in this PR.