Skip to content

fix: adjust import analysis behavior to match Node #16738

Merged
bluwy merged 1 commit intovitejs:mainfrom
stenin-nikita:main
May 29, 2024
Merged

fix: adjust import analysis behavior to match Node #16738
bluwy merged 1 commit intovitejs:mainfrom
stenin-nikita:main

Conversation

@stenin-nikita
Copy link
Copy Markdown
Contributor

Description

fixes #16714


Review PR in StackBlitz Submitted with StackBlitz.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@stenin-nikita stenin-nikita force-pushed the main branch 4 times, most recently from 4a079fa to 5772441 Compare May 21, 2024 15:50
@bluwy
Copy link
Copy Markdown
Member

bluwy commented May 28, 2024

/ecosystem-ci run

@vite-ecosystem-ci
Copy link
Copy Markdown

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr labels May 28, 2024
@bluwy bluwy added this to the 5.3 milestone May 28, 2024
@bluwy
Copy link
Copy Markdown
Member

bluwy commented May 28, 2024

It's a bit hard to tell what failed in Vike, but I think it should be fine.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented May 29, 2024

/ecosystem-ci run vike

@vite-ecosystem-ci
Copy link
Copy Markdown

📝 Ran ecosystem CI on faa197d: Open

suite result latest scheduled
vike failure failure

@bluwy bluwy merged commit f599ab4 into vitejs:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The proxyGuardOnlyEsm does not work consistently

2 participants