feat: add headTagInsertCheck warning#16555
Merged
bluwy merged 2 commits intovitejs:mainfrom May 29, 2024
Merged
Conversation
|
|
sapphi-red
reviewed
Apr 30, 2024
sapphi-red
requested changes
May 1, 2024
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
I guess this warning won't happen that much, but I think the complexity is small enough.
| if (!tags.length) return | ||
| const { logger } = ctx.server?.config || {} | ||
| const message = tags.reduce<string[]>((res, tagDescriptor) => { | ||
| if (!HeadElement[tagDescriptor.tag]) res.push(`<${tagDescriptor.tag}>`) |
Member
There was a problem hiding this comment.
Note for other reviewers: I confirmed that custom elements are not allowed in <head>.
sapphi-red
added
feat: html
p2-nice-to-have
sapphi-red
approved these changes
May 1, 2024
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress |
patak-dev
approved these changes
May 9, 2024
bluwy
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add warning message for
applyHtmlTransforms.there will be an abnormal scene, when we try to use some tags in
headelement, such asdiv.here is an example:
in browser:
it will be better for developer, if
viteprovide some warn message.