Skip to content

Comments

fix: skip encode if is data uri#16233

Merged
patak-dev merged 1 commit intomainfrom
fix-inlined-encode
Mar 22, 2024
Merged

fix: skip encode if is data uri#16233
patak-dev merged 1 commit intomainfrom
fix-inlined-encode

Conversation

@bluwy
Copy link
Member

@bluwy bluwy commented Mar 22, 2024

Description

fix #16229

When encoding arbitrary URIs (especially assets), we need to take account for data: URIs too and skip encoding if so. We didn't handle that which caused the bug at

partialEncodeURIPath(toOutputPublicFilePath(url)),

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Mar 22, 2024
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 8617e76 into main Mar 22, 2024
@patak-dev patak-dev deleted the fix-inlined-encode branch March 22, 2024 12:46
@kkomelin
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p4-important Violate documented behavior or significantly improves performance (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVG inlining broke in 5.2.2

3 participants