feat: add an option to not start a websocket server#16219
Merged
bluwy merged 3 commits intovitejs:mainfrom May 29, 2024
Merged
Conversation
|
|
sheremet-va
added
the
p2-nice-to-have
patak-dev
reviewed
Apr 3, 2024
sheremet-va
force-pushed
the
feat/add-ws-false
branch
from
2ddc0d1 to
6672fd5
Compare
patak-dev
approved these changes
Apr 3, 2024
bluwy
approved these changes
Apr 5, 2024
Member
|
@sheremet-va Is this something you'd like to get out soon? I think we can merge this in a patch since it's not a big change, otherwise if it's not urgent we can queue this for the next minor. |
Member
Author
I am fine with it being in a minor. I am using a workaround by assigning a dummy |
1 task
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option
server.wsthat can only be equal tofalse. I wasn't sure if I should changeserver.hmrtype (make it nullable like the watcher?), so I added a new one. If we want to useserver.hmr, we would need to replace allserver.hmr === false.Also, do we want to document this option?
Closes #14328
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).