fix(worker): throw error when circular worker import is detected and support self referencing worker#16103
Merged
sapphi-red merged 3 commits intovitejs:mainfrom Mar 6, 2024
Conversation
sapphi-red
added
p3-minor-bug
|
|
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ astro, histoire, ladle, laravel, marko, nuxt, previewjs, qwik, rakkas, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
patak-dev
approved these changes
Mar 6, 2024
Member
|
Awesome! Feel free to merge this one if you'd like to see it in a patch. If not, I'll wait for 5.2 |
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The first commit makes Vite to throw an error when a circular worker import is detected.
The second and third commits adds support for simple circular import cases (self reference).
fixes #7015
I didn't add support for complex cases (e.g.
worker-a.jshasimport 'worker-b.js?worker'andworker-b.jshasimport 'worker-a.js?worker'). For those cases, Vite now throw errors (before this PR, the build never finished). But I think it's fine because doing that is not popular and will make the code complex. I checked that supporting the simple cases makes the build of #7015, #7015 (comment), #12755, #14499, #15288, #15426, jamsinclair/jSquash#15 pass.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).