fix: check for publicDir before checking if it is a parent directory#16046
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Mar 11, 2024
Merged
fix: check for publicDir before checking if it is a parent directory#16046sapphi-red merged 1 commit intovitejs:mainfrom
sapphi-red merged 1 commit intovitejs:mainfrom
Conversation
|
|
sapphi-red
approved these changes
Feb 28, 2024
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
This was working in pre-5.1.0 because normalizePath('') is '.'. ea5fdeb changed normalizePath('') into ''.
sapphi-red
added
p3-minor-bug
|
@sapphi-red thanks for the quick approval; when can we expect to see a |
Member
|
I guess in a week. |
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ astro, histoire, ladle, laravel, marko, nuxt, previewjs, qwik, rakkas, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This tries to fix #16034 and adds a condition if publicDir is truthy
Additional context
does this needs a test? i couldn't find tests with publicDir set to false, and i couldn't figure out how to set it up.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).