Skip to content

fix(plugin-legacy): dynamic import browserslist-to-esbuild#16011

Merged
patak-cat merged 2 commits intomainfrom
fix-legacy-cjs
Feb 22, 2024
Merged

fix(plugin-legacy): dynamic import browserslist-to-esbuild#16011
patak-cat merged 2 commits intomainfrom
fix-legacy-cjs

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Feb 22, 2024

Description

fix #15988 (comment)

browserslist-to-esbuild is ESM only, so we need to dynamically import it.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Copy Markdown
Member Author

bluwy commented Feb 22, 2024

/ecosystem-ci run

@patak-cat
Copy link
Copy Markdown
Member

Thanks Bjorn!

It seems Qwik and Rakkas are failing because of a puppeteer issue. Yesterday they were working but it doesn't look like this is in our side:
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/8005837497/job/21866210713#step:8:1253

@vite-ecosystem-ci
Copy link
Copy Markdown

📝 Ran ecosystem CI on 1c61e19: Open

suite result latest scheduled
analogjs success success
astro success success
histoire success success
ladle success success
laravel success success
marko success success
nuxt success success
nx failure failure
previewjs success success
qwik failure success
rakkas failure success
sveltekit success success
unocss success success
vike success success
vite-plugin-pwa success success
vite-plugin-react success success
vite-plugin-react-pages success success
vite-plugin-react-swc success success
vite-plugin-svelte success success
vite-plugin-vue success success
vite-setup-catalogue success success
vitepress success success
vitest success success

@patak-cat patak-cat merged commit 42fd11c into main Feb 22, 2024
@patak-cat patak-cat deleted the fix-legacy-cjs branch February 22, 2024 15:02
@patak-cat patak-cat mentioned this pull request Feb 23, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants