Skip to content

Comments

fix: resolve directory correctly when fs.cachedChecks: true#15983

Merged
patak-dev merged 4 commits intovitejs:mainfrom
sapphi-red:fix/non-normalized-absolute-path
Feb 20, 2024
Merged

fix: resolve directory correctly when fs.cachedChecks: true#15983
patak-dev merged 4 commits intovitejs:mainfrom
sapphi-red:fix/non-normalized-absolute-path

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Feb 20, 2024 •
edited
Loading

Description

I checked this with #15858 and #15901.

fixes #15858
fixes #15901
refs #15279

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Feb 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Feb 20, 2024
@sapphi-red sapphi-red changed the title test: non-normalized absolute path fix: resolve directory correctly when fs.cachedChecks: true Feb 20, 2024
@sapphi-red sapphi-red marked this pull request as ready for review February 20, 2024 12:38
@patak-dev
Copy link
Member

patak-dev commented Feb 20, 2024

Oh, amazing! Thanks for digging into this @sapphi-red. Let's merge it and release a patch. Maybe we could extract this as an util and apply it when we normalize paths in the config too? I was under the impression that the normalized path will not have the trailing / and I think we have some paths expecting that

@patak-dev patak-dev merged commit 4fe971f into vitejs:main Feb 20, 2024
@sapphi-red
Copy link
Member Author

sapphi-red commented Feb 20, 2024

Yeah, maybe we can apply it in normalizePath.

@sapphi-red sapphi-red deleted the fix/non-normalized-absolute-path branch February 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failed to resolve path with alias and React createRoot No fallback to index.js when importing a directory using an alias

2 participants

@sapphi-red @patak-dev