fix(runtime): pass path instead of fileURL to isFilePathESM#15908
Merged
patak-dev merged 1 commit intovitejs:mainfrom Feb 14, 2024
Merged
fix(runtime): pass path instead of fileURL to isFilePathESM#15908patak-dev merged 1 commit intovitejs:mainfrom
isFilePathESM#15908patak-dev merged 1 commit intovitejs:mainfrom
Conversation
sapphi-red
added
the
p3-minor-bug
|
|
sapphi-red
changed the title
isFilePathESM
sapphi-red
commented
Feb 14, 2024
| throw err | ||
| } | ||
| const file = pathToFileURL(resolved.id).toString() | ||
| const type = isFilePathESM(file, server.config.packageCache) |
Member
Author
There was a problem hiding this comment.
When file is file:///C:/Users/green/foo.js, file:///C:/Users/green is passed to findNearestPackageData.
vite/packages/vite/src/node/utils.ts
Line 469 in 7440191
Then,
file:\C:\Users\green\package.json is passed to tryStatSync.vite/packages/vite/src/node/packages.ts
Line 132 in 7440191
fs.statSync('file:\C:\Users\green\package.json') throws Error: ENOENT: no such file or directory, stat 'C:\Users\green\file:C:Usersgreenpackage.json' error.
I didn't actually create a reproduction though.
bluwy
approved these changes
Feb 14, 2024
patak-dev
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).