fix: optimizeDeps.entries with literal-only pattern(s)#15853
Merged
patak-dev merged 3 commits intovitejs:mainfrom Feb 21, 2024
Merged
fix: optimizeDeps.entries with literal-only pattern(s)#15853patak-dev merged 3 commits intovitejs:mainfrom
patak-dev merged 3 commits intovitejs:mainfrom
Conversation
|
|
Contributor
|
I think |
patak-dev
previously approved these changes
Feb 14, 2024
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
This sounds good to me. An alternative would be to let the user specify a pattern that has node_modules, in which case node_modules won't be ignored. Maybe we could also do that in a future PR if needed. But your solution is better for now.
Member
|
/ecosystem-ci run |
patak-dev
added
feat: dev
|
📝 Ran ecosystem CI on
|
Member
|
The AnalogJS fail is unrelated to this PR. |
Contributor
Author
|
So I guess this is ready to merge? @patak-dev 🙂 |
Member
|
We wait for two approvals for this kind of PR. |
bluwy
previously approved these changes
Feb 21, 2024
bluwy
approved these changes
Feb 21, 2024
patak-dev
approved these changes
Feb 21, 2024
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip running
fast-globifoptimizeDeps.entriesis specified without any special characters like$^*+?[]().So user can specify a entry in literal value to skip the
fast-globignore policy.Additional context
#15613 (reply in thread)
#15746
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).