fix: empty CSS file was output when only .css?url is used#15846
Merged
patak-dev merged 1 commit intovitejs:mainfrom Feb 8, 2024
Merged
Conversation
sapphi-red
added
bug
feat: css
p2-nice-to-have
|
|
sapphi-red
commented
Feb 8, 2024
Comment on lines
-721
to
-723
| if (!chunkCSS && !s) { | ||
| return null | ||
| } |
Member
Author
There was a problem hiding this comment.
If a file contains __VITE_CSS_URL__ (!s === false) and doesn't have side effect CSS imports (e.g. import './foo.css') (!chunkCSS === true), the if-else block below should not run and if (s) block should run.
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
|
patak-dev
approved these changes
Feb 8, 2024
sapphi-red
deleted the
fix/empty-css-file-output-when-only-css-url-import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
import u from './foo.css?url'is used andimport './bar.css'is not used, an empty CSS file was output.fixes #15843
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).