fix: skip not only .js but also .mjs manifest entries#15841
Merged
patak-dev merged 4 commits intovitejs:mainfrom Feb 8, 2024
Merged
fix: skip not only .js but also .mjs manifest entries#15841patak-dev merged 4 commits intovitejs:mainfrom
patak-dev merged 4 commits intovitejs:mainfrom
Conversation
|
|
5106998 to
a79c894
Compare
Contributor
Author
|
I think the CI is green; the one failure seems to be a falky test. |
patak-dev
approved these changes
Feb 8, 2024
sapphi-red
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current manifest generation logic is faulty if
manifest[src].fileends with.mjsinstead of.js. This PR fixes it.Additional context
This bug is breaking a production app.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).