fix: disable fs.cachedChecks for custom watch ignore patterns#15828
Merged
fix: disable fs.cachedChecks for custom watch ignore patterns#15828
Conversation
|
|
patak-dev
added
the
p3-minor-bug
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
|
bluwy
approved these changes
Feb 7, 2024
patak-dev
deleted the
fix/disable-fs-cached-checks-for-custom-watch-ignore
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We're seeing issues with
fs.cachedChecksin Vitest in playgrounds that build a SSR bundle todist.Vitest has a default ignore rule that is making files added to
distinvisible to the new cache: https://github.com/vitest-dev/vitest/blob/6f5b42b7a8e8a3c2ddb1c6876ea474553d686e28/packages/vitest/src/defaults.ts#L78While we find a good way to work out these issues (it may be that the tests should be reworked, or that there is a way to support this in the fs cache), this PR disables the cache by default if there are custom rules.
What is the purpose of this pull request?