Skip to content

Comments

fix(build): do not output build time when build fails#15711

Merged
patak-dev merged 8 commits intovitejs:mainfrom
btea:fix/build-fail-should-not-print-built-time
Feb 12, 2024
Merged

fix(build): do not output build time when build fails#15711
patak-dev merged 8 commits intovitejs:mainfrom
btea:fix/build-fail-should-not-print-built-time

Conversation

@btea
Copy link
Contributor

@btea btea commented Jan 25, 2024

Description

The solution to this problem in #14761 is to make the judgment in the buildEnd hook. However, when encountering the problem in #15461, I found that buildEnd could not receive errors in the plugin's generateBundle hook.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-dev
patak-dev previously approved these changes Feb 12, 2024
@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 12, 2024
@patak-dev patak-dev merged commit added3e into vitejs:main Feb 12, 2024
@btea btea deleted the fix/build-fail-should-not-print-built-time branch February 13, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants