fix: init dev ssr optimizer on server init#15561
Merged
Conversation
|
|
6 tasks
patak-dev
added
p3-downstream-blocker
sheremet-va
reviewed
Jan 10, 2024
sheremet-va
approved these changes
Jan 10, 2024
9 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are starting warmup of ssr files using
transformRequeston server init. The dev ssr optimizer was started lazily onssrLoadModuleto avoid blocking the server start. The esbuild run should be fast enough for this move to not be a regression in DX.Edit: moved the init to be lazy in transformRequest
vite-node isn't using
ssrLoadModulein SSR transform mode so the deps optimizer wasn't working properly in Vitest either. See:cc @sheremet-va
What is the purpose of this pull request?