fix(worker): replace import.meta correctly for IIFE worker#15321
Merged
patak-cat merged 4 commits intovitejs:mainfrom Dec 12, 2023
Merged
fix(worker): replace import.meta correctly for IIFE worker#15321patak-cat merged 4 commits intovitejs:mainfrom
import.meta correctly for IIFE worker#15321patak-cat merged 4 commits intovitejs:mainfrom
Conversation
|
|
XiSenao
changed the title
XiSenao
force-pushed
the
fix/import-meta-compilation-error
branch
from
65d033d to
4c40667
Compare
XiSenao
force-pushed
the
fix/import-meta-compilation-error
branch
from
4c40667 to
a00f6f6
Compare
Collaborator
Author
|
It seems that the behavior of recent |
sapphi-red
added
p3-minor-bug
sapphi-red
reviewed
Dec 12, 2023
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
Thanks! Would you add a test?
Member
Yeah, it seems quite flaky. |
sapphi-red
changed the title
import.meta correctly for IIFE worker
Collaborator
Author
Yeah, I can provide test cases. |
sapphi-red
approved these changes
Dec 12, 2023
patak-cat
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #15310
fix #15305
refs #12629
Additional context
We may also need to compile
import.metato avoid errors when using it directly inworker. this modification is consistent with the development environment, andimport.metaonly exposes theurlproperty.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).