Skip to content

refactor: use dedicated regex methods#15228

Merged
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:refactor/use-dedicated-regex-methods
Dec 3, 2023
Merged

refactor: use dedicated regex methods#15228
patak-cat merged 2 commits intovitejs:mainfrom
sapphi-red:refactor/use-dedicated-regex-methods

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

  • use hasIndices flag (d)
  • foo.slice(ops).match(regex) -> regex.lastIndex = pos; regex.exec(foo)
  • !!foo.match(regex) -> regex.test(foo)
  • !!foo.match(string) -> foo.includes(string)
  • foo.match(regex)?.index -> foo.search(regex)
  • regex.test() -> .startsWith()/.endsWith()/.includes()
  • expect(foo.match(string)).toBeNull() -> expect(foo).toContain(string)
  • (fix) add .lastIndex = 0 before /something/g.test(something)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 3, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@patak-cat patak-cat merged commit 0348137 into vitejs:main Dec 3, 2023
@sapphi-red sapphi-red deleted the refactor/use-dedicated-regex-methods branch December 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants