fix: emit vite:preloadError for chunks without deps#15203
Merged
patak-cat merged 1 commit intovitejs:mainfrom Dec 1, 2023
Merged
fix: emit vite:preloadError for chunks without deps#15203patak-cat merged 1 commit intovitejs:mainfrom
vite:preloadError for chunks without deps#15203patak-cat merged 1 commit intovitejs:mainfrom
Conversation
sapphi-red
added
the
p3-minor-bug
|
|
This was referenced Dec 1, 2023
Member
Author
|
I think we should add a section about |
patak-cat
approved these changes
Dec 1, 2023
Member
|
I think we can add the section in the docs in another PR. Maybe another section after Chunking Strategy? (we could also think of removing the vendor plugin bits from Chunking Strategy, it may not be needed there anymore) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the loaded chunk didn't have any deps,
vite:preloadErrorwas not emitted.For example, the event is not emitted for https://stackblitz.com/edit/vitejs-vite-ho9n9z?file=main.js,counter.js and is emitted for https://stackblitz.com/edit/vitejs-vite-eubg1i?file=main.js,counter.js
The difference between them is that
counter.jsimportscounter.cssin the latter one.refs #12084
/cc @danielroe
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).