fix: generateCodeFrame infinite loop#15093
Merged
patak-cat merged 2 commits intovitejs:mainfrom Nov 22, 2023
Merged
Conversation
sapphi-red
added
the
p4-important
sapphi-red
commented
Nov 22, 2023
Comment on lines
+509
to
+512
| end = Math.min( | ||
| end !== undefined ? posToNumber(source, end) : start, | ||
| source.length, | ||
| ) |
Member
Author
There was a problem hiding this comment.
vite/packages/vite/src/node/plugins/css.ts
Lines 1199 to 1202 in bcc4a61
{ endLine: 107, endColumn: 2 } was passed here. So posToNumber(source, { line: 107, column: 1 }) was called.But the
source only has 107 lines. So posToNumber returned a number greater than source.length.
patak-cat
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #15076
refs #14984
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).