Skip to content

chore: add comment about crossorigin attribute for script module#15040

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:chore/add-comment-about-crossorigin
Nov 20, 2023
Merged

chore: add comment about crossorigin attribute for script module#15040
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:chore/add-comment-about-crossorigin

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

I didn't know about the reason why crossorigin attribute is set for <script type="module">. Digging around the crossorigin attribute and <link rel="preload">, I guess this is the reason.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 20, 2023
@patak-cat patak-cat merged commit 03c371e into vitejs:main Nov 20, 2023
@sapphi-red sapphi-red deleted the chore/add-comment-about-crossorigin branch November 20, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants