Skip to content

fix: add watch in fallback file load#14938

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/add-watch-file-fallback
Nov 10, 2023
Merged

fix: add watch in fallback file load#14938
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/add-watch-file-fallback

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

Files that were loaded by the fallback file load were not added to watcher.

fixes #14927
refs #14508

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Nov 10, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Nov 10, 2023
@sapphi-red sapphi-red force-pushed the fix/add-watch-file-fallback branch from b70073f to 7556eaf Compare November 10, 2023 09:47
@patak-cat patak-cat enabled auto-merge (squash) November 10, 2023 09:51
@patak-cat patak-cat merged commit b24b951 into vitejs:main Nov 10, 2023
@sapphi-red sapphi-red deleted the fix/add-watch-file-fallback branch November 10, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p4-important Violate documented behavior or significantly improves performance (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[5.0 Beta 10+] file change Watch no longer detect changes in workspace since Rollup 4

2 participants