docs(ssr): properly handle vite.middlewares after restart#14917
Merged
docs(ssr): properly handle vite.middlewares after restart#14917
Conversation
Co-authored-by: Bjorn Lu <[email protected]>
bluwy
reviewed
Nov 9, 2023
Co-authored-by: Bjorn Lu <[email protected]>
bluwy
approved these changes
Nov 9, 2023
This was referenced Nov 15, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See:
server.headersafter restart in middleware mode #14905vite.middlewaresis updated after a restart inmiddlewareMode: true. We need to recommend an indirection so users always get the latest middlewares, as proposed by @bluwy hereWe could try to make
vite.middlewaresmore magical and avoid reassigning in the future, but it isn't bad either that users know the middlewares change after a restart explicitly.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).