Skip to content

test: avoid read check when running as root#14884

Merged
bluwy merged 2 commits intovitejs:mainfrom
summer-boythink:main
Nov 21, 2023
Merged

test: avoid read check when running as root#14884
bluwy merged 2 commits intovitejs:mainfrom
summer-boythink:main

Conversation

@summer-boythink
Copy link
Copy Markdown
Contributor

Description

When I clone the repository with root and run test, I find that I get an error

Snipaste_2023-11-06_10-23-19

I learned that root always has permission to read a file, so I thought I'd add an if statement before this test


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@summer-boythink summer-boythink changed the title fix:The root permission to read files fix: the root permission to read files Nov 6, 2023
patak-cat
patak-cat previously approved these changes Nov 7, 2023
@patak-cat patak-cat added the test label Nov 7, 2023
@patak-cat patak-cat changed the title fix: the root permission to read files test: avoid read check when running as root Nov 7, 2023
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy merged commit 1d9516c into vitejs:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants