fix(css): initialize lightningCSS targets when not using options#14872
Merged
fix(css): initialize lightningCSS targets when not using options#14872
Conversation
|
|
ArnaudBarre
added
the
p2-edge-case
sapphi-red
reviewed
Nov 4, 2023
sapphi-red
approved these changes
Nov 4, 2023
bluwy
approved these changes
Nov 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a weird behaviour where:
was not the same as
Because without any targets LightningCSS will default to latest specs and do a lot of syntax shortening and vendor-prefixing cleanup, this should always be set to avoid sending non supported CSS to the browser.