Skip to content

fix: serve 404.html also for SSR apps/frameworks#14837

Closed
brillout wants to merge 2 commits intovitejs:mainfrom
brillout:brillout/fix-preview-404
Closed

fix: serve 404.html also for SSR apps/frameworks#14837
brillout wants to merge 2 commits intovitejs:mainfrom
brillout:brillout/fix-preview-404

Conversation

@brillout
Copy link
Copy Markdown
Contributor

@brillout brillout commented Oct 31, 2023 •
edited
Loading

Description

Same logic as #14836.

Someone should run /ecosystem-ci run against this PR.

(I've made two PRs because I'm much less confident Vite's eco CI will be green for this PR.)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy reviewed Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can always handle 404s because in middlewareMode + appType: 'custom' combo, the consumer will be unable to create middlewares after Vite's middlewares with this PR.

@brillout
Copy link
Copy Markdown
Contributor Author

brillout commented Nov 1, 2023

AFAIK Vite doesn't have a middleware mode for the preview server.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Nov 1, 2023

Hmm right I forgot this is for preview only.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Nov 1, 2023

We talked about this today. Generally we're pretty indifferent, but since configurePreviewServer allows you to "fix" this today, aligning to the dev behaviour seems like the better option instead. If appType: 'custom' is configured, you would have to handle 404 in dev, so the same should also happen in preview too.

There's more discussed by I'll continue at #14836

@bluwy bluwy mentioned this pull request Nov 2, 2023
Merged
9 tasks
@brillout brillout closed this Nov 2, 2023
@brillout brillout deleted the brillout/fix-preview-404 branch September 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brillout @bluwy