refactor(esbuild)!: remove esbuild 0.17 -> 0.18 compat#14804
Merged
Conversation
|
|
sapphi-red
reviewed
Oct 30, 2023
docs/guide/migration.md
Outdated
|
|
||
| ### Update `experimentalDecorators` and `useDefineForClassFields` TypeScript behaviour | ||
|
|
||
| Vite 5 uses esbuild 0.18, which changes how `experimentalDecorators` and `useDefineForClassFields` are handled. |
Member
There was a problem hiding this comment.
Vite 5 uses esbuild 0.19 (#14430). So I think we need to say it like "we removed the compat layer".
Member
Author
There was a problem hiding this comment.
Ah yeah we should mention it's 0.19 now. I point out as 0.18 as the main compat layer was for 0.18. 0.19 was not much breaking I believe. I can update it before merging.
sapphi-red
previously approved these changes
Oct 30, 2023
Member
sapphi-red
left a comment
sapphi-red
left a comment
There was a problem hiding this comment.
The migration guide can be tweaked later so I think it's fine to merge it to test out the changes.
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
|
patak-dev
approved these changes
Oct 30, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed esbuild 0.17 to 0.18 compat code we added in Vite 4. I only saw this comment that we should remove this in Vite 5 just now 😬
experimentalDecoratorsneeds to be enabled if usedsupportedhandling foruseDefineForClassFields. I figured it's better to document what's happening and how they can fix it. I initially thought we could respectesbuild.compilerOptions.targetand overrideesbuild.targetif set, but I don't think it's worth breaking that now, nor a good default. This is also esbuild's behaviour.I added some documentation to explain what's going on.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).