Skip to content

refactor!: remove non boolean middleware mode#14792

Merged
bluwy merged 2 commits intovitejs:mainfrom
sapphi-red:refactor-remove-non-boolean-middleware-mode
Oct 30, 2023
Merged

refactor!: remove non boolean middleware mode#14792
bluwy merged 2 commits intovitejs:mainfrom
sapphi-red:refactor-remove-non-boolean-middleware-mode

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Oct 29, 2023

Description

This PR removes the non boolean middleware mode option which is deprecated by #8452 since Vite 3.

github search result

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) breaking change labels Oct 29, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Oct 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red
Copy link
Copy Markdown
Member Author

sapphi-red commented Oct 29, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link
Copy Markdown

vite-ecosystem-ci bot commented Oct 29, 2023

📝 Ran ecosystem CI on b526367: Open

suite result latest scheduled
analogjs ✅ success ✅ success
astro ✅ success ✅ success
histoire ✅ success ✅ success
ladle ✅ success ✅ success
laravel ❌ failure ❌ failure
marko ❌ failure ❌ failure
nuxt ❌ failure ❌ failure
nx ❌ failure ❌ failure
previewjs ❌ failure ✅ success
qwik ✅ success ✅ success
rakkas ✅ success ✅ success
sveltekit ❌ failure ❌ failure
unocss ✅ success ✅ success
vike ✅ success ✅ success
vite-plugin-pwa ✅ success ✅ success
vite-plugin-react ✅ success ✅ success
vite-plugin-react-pages ✅ success ✅ success
vite-plugin-react-swc ✅ success ✅ success
vite-plugin-svelte ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vite-setup-catalogue ✅ success ✅ success
vitepress ✅ success ✅ success
vitest ❌ failure ❌ failure

@bluwy bluwy merged commit deb5515 into vitejs:main Oct 30, 2023
@sapphi-red sapphi-red deleted the refactor-remove-non-boolean-middleware-mode branch October 30, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

breaking change p1-chore Doesn't change code behavior (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @patak-cat @bluwy