refactor(shortcuts)!: tweak shortcuts api#14749
Merged
Conversation
|
|
bluwy
force-pushed
the
shortcut-refactor
branch
from
ae30c2d to
8d5fdd5
Compare
ArnaudBarre
reviewed
Oct 25, 2023
Member
Author
|
I think for |
patak-cat
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tighten up the shortcuts implementation a bit before Vite 5
customShortcutsonly an array of shortcuts. Doesn't supportnull | undefinedarray elements.hhelp shortcut. E.g. if user defines thershortcut to do something else (and not restart the server), we should only print it once.hshortcut as we always handle it.Additional context
One thing I wonder is if we should allow users to override the
hshortcut, but that makes the code a bit ugly and could also be tackled non-breakingly in the future.Slightly related discussion: #8746 (comment)
What is the purpose of this pull request?