feat!: rollup v4 by sapphi-red · Pull Request #14508 · vitejs/vite

sapphi-red · 2023-09-30T14:44:32Z

Description

This PR upgrades Rollup to v4.

Remaining TODOs:

Check if this.addWatchFile is needed in other places
Revert "remove utf8 BOM for now" commit once [v4] Invalid variable name generated when importing from UTF-8 with BOM file rollup/rollup#5162 is fixed
Wait for rollup v4 to be released and bump version in package.json
Wait for rollup-plugins compatible with Rollup v4 to be released

refs rollup/rollup#5140
close #13342

Additional context

`this.parse`

Rollup now uses SWC with a custom tree converter (converts SWC AST to ESTree AST) to parse JS.

This PR gets this.parse from rollup by creating a dummy bundle and uses that in dev. I'm not sure if this is legal 😅
This way we can be 100% compatible with rollup.

The other way is to use acorn in dev. But it seems even if we added both acorn-import-attributes and acorn-import-assertions, acorn cannot parse asserts. So we have to create our own acorn plugin or remove support for either asserts if we take this way.

`skipSelf: true` is now default

Maybe #13852 should be given more priority now.

What is the purpose of this pull request?

Bug fix
New Feature
Documentation update
Other

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Read the Pull Request Guidelines and follow the PR Title Convention.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

…tions to `this.parse`

removed by rollup/rollup#5147

packages/vite/src/node/ssr/ssrTransform.ts

playground/resolve/utf8-bom/main.js

sapphi-red · 2023-09-30T16:20:13Z

Most of the fails are type incompatibility errors.

This analog fail might be a bug in rollup.
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/6363871721/job/17279764712#step:8:866

bluwy

Changes look great so far. Nice to see there's not too many change needed on our end.

packages/vite/src/node/server/pluginContainer.ts

This reverts commit 4d49292.

sapphi-red · 2023-10-03T10:42:46Z

Back to green 🫡
Lint CI is failing because vitepress is failing to build. I guess vitepress needs to tweak some code (replace \w+ with [-\w]+ in some places) to work with the new hash algorithm.

lukastaegert · 2023-10-05T12:58:40Z

All Rollup plugins (except sucrase, there was a weird hiccup in the pipeline) have been updated (thought the changelog does not reflect it...).

sapphi-red · 2023-10-06T11:27:43Z

No problem 😃 Hmm, I see. Yeah, it seems to be working like that 🧐
https://github.com/vitejs/vite/actions/runs/6430200937/job/17461260148?pr=14508#step:2:81

sapphi-red · 2023-10-12T16:17:00Z

/ecosystem-ci run

vite-ecosystem-ci · 2023-10-12T16:17:25Z

📝 Ran ecosystem CI: Open

suite	result
analogjs	✅ success
astro	❌ failure
histoire	❌ failure
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	❌ failure
nx	❌ failure
previewjs	✅ success
qwik	❌ failure
rakkas	✅ success
sveltekit	❌ failure
unocss	❌ failure
vike	❌ failure
vite-plugin-pwa	✅ success
vite-plugin-react	✅ success
vite-plugin-react-pages	❌ failure
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	❌ failure
vite-setup-catalogue	✅ success
vitepress	❌ failure
vitest	❌ failure

bluwy

LGTM. If we want to stay on track with the release schedule, I think we should merge this as soon as possible.

To make the ecosystem-ci slightly greener so we don't catch type issues, maybe we can override rollup to v4 too.

bluwy · 2023-10-15T13:29:33Z

/ecosystem-ci run

vite-ecosystem-ci · 2023-10-15T13:30:00Z

📝 Ran ecosystem CI: Open

suite	result
analogjs	✅ success
astro	❌ failure
histoire	✅ success
ladle	✅ success
laravel	✅ success
marko	✅ success
nuxt	✅ success
nx	❌ failure
previewjs	✅ success
qwik	❌ failure
rakkas	✅ success
sveltekit	❌ failure
unocss	✅ success
vike	❌ failure
vite-plugin-pwa	❌ failure
vite-plugin-react	✅ success
vite-plugin-react-pages	✅ success
vite-plugin-react-swc	✅ success
vite-plugin-svelte	✅ success
vite-plugin-vue	❌ failure
vite-setup-catalogue	✅ success
vitepress	✅ success
vitest	❌ failure

segevfiner · 2023-10-17T18:05:13Z

Isn't parse exposed from rollup/parseAst https://rollupjs.org/javascript-api/#accessing-the-parser, so you don't really need the dummy bundle trick?

bluwy · 2023-10-17T18:07:59Z

Yeah we've updated to use that now. It was discussed at #14508 (comment)

sapphi-red added 8 commits September 30, 2023 16:45

wip: bump rollup

8596dfd

wip: remove acorn/acornInjectPlugins option, remove additional op…

b907e6e

…tions to `this.parse`

wip: replace "assertions" with "attributes"

e6474ba

wip: replace RollupWarning with RollupLog

00e0ece

removed by rollup/rollup#5147

wip: remove omit moduleIds

0c488c7

wip: call this.addWatchFile in vite:load-fallback plugin

d9085f7

wip: remove utf8 BOM for now

4d49292

wip: use parse function from rollup

f161d22

sapphi-red added breaking change p3-significant High priority enhancement (priority) labels Sep 30, 2023

wip: bump rollup for plugin-legacy

ddde37f

sapphi-red commented Sep 30, 2023

View reviewed changes

packages/vite/src/node/ssr/ssrTransform.ts Outdated Show resolved Hide resolved

sapphi-red commented Sep 30, 2023

View reviewed changes

playground/resolve/utf8-bom/main.js Outdated Show resolved Hide resolved

sapphi-red added 2 commits October 1, 2023 00:20

wip: default of skipSelf is now true

49dafa0

wip: ignore rollup version mismatch type error

176f6d5

sapphi-red force-pushed the feat/rollup-4 branch from ef728b9 to 176f6d5 Compare September 30, 2023 15:20

This comment was marked as outdated.

Sign in to view

bluwy reviewed Oct 2, 2023

View reviewed changes

packages/vite/src/node/server/pluginContainer.ts Outdated Show resolved Hide resolved

sapphi-red added 5 commits October 3, 2023 18:23

wip: bump rollup

9f36ca3

wip: revert "wip: remove utf8 BOM for now"

6b00745

This reverts commit 4d49292.

wip: new hash algorithm

632d3b0

wip: new hash algorithm

a3c750f

wip: new hash algorithm

ae0b4c4

sapphi-red added 3 commits October 5, 2023 22:52

chore: merge main

fa7a370

chore: update rollup plugins

e5bf794

wip: update rollup

a274f82

sapphi-red added 2 commits October 9, 2023 18:44

chore: merge main

31ed8b1

chore: merge main

0728839

sapphi-red mentioned this pull request Oct 11, 2023

chore: make it work with rollup v4 vuejs/vitepress#3065

Merged

sapphi-red added 2 commits October 13, 2023 01:04

chore: merge main

3d081e3

chore: bump vitepress

8915ca5

bluwy previously approved these changes Oct 13, 2023

View reviewed changes

sapphi-red added 2 commits October 16, 2023 16:33

chore: merge main

22d7bd9

chore: bump rollup-plugin-license

d5bd340

sapphi-red dismissed bluwy’s stale review via d5bd340 October 16, 2023 07:34

chore: bump rollup and magic-string

72a4624

bluwy previously approved these changes Oct 16, 2023

View reviewed changes

chore: merge main

6a5d4dd

sapphi-red dismissed bluwy’s stale review via 6a5d4dd October 16, 2023 14:36

sapphi-red mentioned this pull request Oct 17, 2023

chore: make tests pass with rollup4 vitejs/vite-plugin-vue#271

Merged

9 tasks

bluwy approved these changes Oct 17, 2023

View reviewed changes

bluwy merged commit dee6067 into vitejs:main Oct 17, 2023

arbassett mentioned this pull request Oct 17, 2023

Vite plugins drop import attributes/assertions property only from src not node_modules #14674

Open

7 tasks

sapphi-red deleted the feat/rollup-4 branch October 17, 2023 19:15

Dunqing mentioned this pull request Oct 31, 2023

chore!: update vite@5 and rollup@4 vitest-dev/vitest#4368

Merged

6 tasks

sapphi-red mentioned this pull request Nov 10, 2023

fix: add watch in fallback file load #14938

Merged

9 tasks

patak-dev mentioned this pull request Jan 16, 2024

perf: lazy load rollup during dev #15621

Merged

4 tasks

sapphi-red mentioned this pull request Jan 7, 2025

Vite dev watcher breaks with "EBUSY: resource busy or locked" #19117

Closed

7 tasks

sm17p mentioned this pull request Jul 18, 2025

fix(rolldown-compat): Only apply footer to content and unlisted scripts via plugin wxt-dev/wxt#1793

Merged

Uh oh!

Comments

Conversation

sapphi-red commented Sep 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context

this.parse

skipSelf: true is now default

What is the purpose of this pull request?

Before submitting the PR, please make sure you do the following

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

sapphi-red commented Sep 30, 2023

Uh oh!

bluwy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sapphi-red commented Oct 3, 2023

Uh oh!

lukastaegert commented Oct 5, 2023

Uh oh!

sapphi-red commented Oct 6, 2023

Uh oh!

sapphi-red commented Oct 12, 2023

Uh oh!

vite-ecosystem-ci bot commented Oct 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bluwy left a comment

Choose a reason for hiding this comment

Uh oh!

bluwy commented Oct 15, 2023

Uh oh!

vite-ecosystem-ci bot commented Oct 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

segevfiner commented Oct 17, 2023

Uh oh!

bluwy commented Oct 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sapphi-red commented Sep 30, 2023 •

edited

Loading

`this.parse`

`skipSelf: true` is now default

vite-ecosystem-ci bot commented Oct 12, 2023 •

edited

Loading

vite-ecosystem-ci bot commented Oct 15, 2023 •

edited

Loading