fix(import-analysis): preserve importedUrls import order#14465
Merged
fix(import-analysis): preserve importedUrls import order#14465
Conversation
bluwy
added
the
p3-downstream-blocker
|
|
1 task
Contributor
|
I've looked into this before. I thought it was intentional. |
Member
Author
|
It was deterministic before #12754 so very likely unintentional here 😬 Though there is a point that |
patak-dev
approved these changes
Sep 26, 2023
bluwy
added a commit
that referenced
this pull request
Oct 3, 2023
bluwy
added a commit
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix withastro/astro#8044
In import analysis, we're transforming the imports populate
importedUrlsin parallel, causing it to be non-deterministic. This affects frameworks that crawl the module graph for CSS to populate the HTML to prevent FOUC, e.g. SvelteKit and Astro (afaia), causing the CSS order to be incorrect.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).