fix: respect resolve.conditions during nodeResolve#14417
Closed
himself65 wants to merge 1 commit intovitejs:mainfrom
Closed
fix: respect resolve.conditions during nodeResolve#14417himself65 wants to merge 1 commit intovitejs:mainfrom
resolve.conditions during nodeResolve#14417himself65 wants to merge 1 commit intovitejs:mainfrom
Conversation
|
|
Author
|
/cc @nksaraf |
himself65
force-pushed
the
himself65/conditions
branch
from
2fcddae to
f92ed86
Compare
Merged
9 tasks
Member
|
Hi @himself65, sorry that we haven't looked into this. It was in draft so I assumed it wasn't ready yet. We've merged #14498 that has implemented this and will close this for now. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on upstream: #13487, but add e2e test coverage