Skip to content

fix: correct line for less errors#14381

Closed
HigherOrderLogic wants to merge 1 commit intovitejs:mainfrom
HigherOrderLogic:main
Closed

fix: correct line for less errors#14381
HigherOrderLogic wants to merge 1 commit intovitejs:mainfrom
HigherOrderLogic:main

Conversation

@HigherOrderLogic
Copy link
Copy Markdown

@HigherOrderLogic HigherOrderLogic commented Sep 15, 2023

Description

Closes #14312

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Sep 15, 2023

Are you sure this fixes the issue? #14312 (comment) mentions to + 1 the column, not the line. Can you show a before and after error message of the change?

@HigherOrderLogic
Copy link
Copy Markdown
Author

HigherOrderLogic commented Sep 15, 2023

Are you sure this fixes the issue? #14312 (comment) mentions to + 1 the column, not the line. Can you show a before and after error message of the change?

image

I'm pretty sure this PR fixes the issue.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Sep 15, 2023

I don't think that caret is pointing in the right place either, it's outside of the column?

@HigherOrderLogic
Copy link
Copy Markdown
Author

HigherOrderLogic commented Sep 15, 2023

I don't think that caret is pointing in the right place either, it's outside of the column?

Maybe that's intended? When I edit to column: error.column + 1, the caret point to the i of @import.

@bluwy
Copy link
Copy Markdown
Member

bluwy commented Sep 17, 2023

Pointing at the i of @import looks more correct as it's the import statement that's failing, although not completely accurate too perhaps. Maybe worth testing different kinds of less errors and check if the changes are correct?

Otherwise, I'd still opt to bumping the column instead.

@sapphi-red sapphi-red mentioned this pull request Nov 14, 2023
Merged
9 tasks
@bluwy bluwy closed this in #14984 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Caret in on-screen error output points to the wrong line

2 participants

@HigherOrderLogic @bluwy