fix(node): ctrl + c closes the server without exit code#14319
Closed
btea wants to merge 1 commit intovitejs:mainfrom
Closed
fix(node): ctrl + c closes the server without exit code#14319btea wants to merge 1 commit intovitejs:mainfrom
ctrl + c closes the server without exit code#14319btea wants to merge 1 commit intovitejs:mainfrom
Conversation
|
|
btea
changed the title
ctr + c closes the server without exit codectrl + c closes the server without exit code
Member
|
Exit 1 is intentional in #11563, however in Vite 5 we also plan to move away from |
Contributor
Author
|
OK, thank you for the reference link. However, as the comment says, the return statement can perhaps be removed. Maybe we can wait until your Vite 5 plan to solve it together. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the shutdown process includes an exit code, it looks like something went wrong.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).