Run & review this pull request in StackBlitz Codeflow.

IIUC this PR transforms dynamic imports with __vitePreload to still preserve the const { ... } = await import('...') syntax temporarily so it still works? It's a bit hard to see how it transforms without more comments or snapshots 😬

But I think the regex and implementation is fairly impressive. I'd lean to a more robust alternative still, but it's also harder. Ideally if __vitePreload is only injected in the render phase, but that makes the preload code hard to be chunked. So perhaps this is good enough for now.

IIUC this PR transforms dynamic imports with __vitePreload to still preserve the const { ... } = await import('...') syntax temporarily so it still works?

Yeah, that's what this pr mainly does. The regexp contains three sub-regexps related to three dynamic import formats, e.g:

• const {foo} = await import('foo')
• (await import('foo')).foo
• import('foo').then(({foo})=>{})

After injecting __vitePreload, they will be transformed to something like:

• const {foo} = await __vitePreload(async () => { const {foo} = await import('foo');return {foo}}, ...)
• __vitePreload(async () => { const {foo} = await import('foo');return { foo }},...).then(({foo})=>{})
• __vitePreload(async () => { const __vite_temp__ = (await import('foo')).foo; return { foo: __vite_temp__ }},...)).foo

/ecosystem-ci run

📝 Ran ecosystem CI on efd904b: Open

✅ analogjs, astro, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, remix, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress