Skip to content

Comments

fix: initWasm options should be optional#14152

Merged
bluwy merged 1 commit intovitejs:mainfrom
btea:fix/wasm-importObject-optional
Aug 18, 2023
Merged

fix: initWasm options should be optional#14152
bluwy merged 1 commit intovitejs:mainfrom
btea:fix/wasm-importObject-optional

Conversation

@btea
Copy link
Contributor

@btea btea commented Aug 18, 2023

Description

The importObject parameter is optional.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

sapphi-red
sapphi-red approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

vite/packages/vite/src/node/plugins/wasm.ts

Lines 71 to 72 in bd9b749

import initWasm from "${wasmHelperId}"
export default opts => initWasm(opts, ${JSON.stringify(url)})

vite/packages/vite/src/node/plugins/wasm.ts

Line 7 in bd9b749

const wasmHelper = async (opts = {}, url: string) => {

@sapphi-red sapphi-red added p2-edge-case Bug, but has workaround or limited in scope (priority) feat: wasm labels Aug 18, 2023
@bluwy bluwy merged commit 387a6e8 into vitejs:main Aug 18, 2023
@btea btea deleted the fix/wasm-importObject-optional branch August 18, 2023 23:46
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix: initWasm options should be optional (#14152)
65df270
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix: initWasm options should be optional (#14152)
119c074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

feat: wasm p2-edge-case Bug, but has workaround or limited in scope (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@btea @bluwy @sapphi-red