fix!: avoid rewriting this (reverts #5312)#14098
Merged
Conversation
|
|
bluwy
approved these changes
Aug 14, 2023
sapphi-red
approved these changes
Aug 16, 2023
Member
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
Member
Author
|
Same failures as in main, it will take some time to get everyone green again. We can merge this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12340
Description
This PR reverts #5312. As it was discussed in #12340, Vite shouldn't be replacing
thisin an ESM context.@ArnaudBarre, #5312 was intended to avoid
THIS_IS_UNDEFINEDwarnings in React apps, but we're already ignoring this warning here:vite/packages/vite/src/node/build.ts
Line 876 in 63a4451
If there is a warning or error in source maps to be avoided though, we should fix it without the need for this rewrite.
As proposed by @bluwy, we can merge this in Vite 5 as it is a breaking change.
What is the purpose of this pull request?