refactor: simplify SSR options' if statement#13254
Merged
patak-cat merged 1 commit intovitejs:mainfrom May 22, 2023
Merged
Conversation
|
|
patak-cat
reviewed
May 18, 2023
packages/vite/src/node/ssr/index.ts
Outdated
| format = 'cjs' | ||
| } else { | ||
| format = 'cjs' | ||
| if (!ssr) { |
Member
There was a problem hiding this comment.
target is already 'node', we can remove this condition too. Note: We plan to remove CJS external heuristics support in Vite 5. If you are using it for some reason, please comment on #12466. We hope to move to ESM only for SSR as all services now properly support ESM.
patak-cat
approved these changes
May 18, 2023
Saeed-Paris
force-pushed
the
refactore-ssr-options
branch
from
d7acd98 to
668ec2c
Compare
sapphi-red
approved these changes
May 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
nothing fancy or important. just noticed that
buildSsrCjsExternalHeuristicsfunction had same statement in both if and else (Hope this wasn't a wierd edge case)Happy first Vite contribution 🥳🥳🥳
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).