fix(ssr): skip updateCjsSsrExternals if legacy flag disabled#13230
Merged
fix(ssr): skip updateCjsSsrExternals if legacy flag disabled#13230
Conversation
bluwy
added
p2-nice-to-have
|
|
patak-cat
approved these changes
May 17, 2023
Member
patak-cat
left a comment
patak-cat
left a comment
There was a problem hiding this comment.
Interesting we missed this one for so long
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
updateCjsSsrExternalsfunction updatesserver._ssrExternalsthat's only used here:vite/packages/vite/src/node/plugins/importAnalysis.ts
Lines 488 to 493 in 3224a51
Since that code only runs on
config.legacy?.buildSsrCjsExternalHeuristics: true, we can also add the same guard forupdateCjsSsrExternalsAdditional context
cc @delucis who found this. It was logging the
... doesn't appear to be written in CJS ...warning unnecessarily.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).