Skip to content

fix: allow using vite as a proxy for another vite server#13218

Merged
patak-cat merged 3 commits intovitejs:mainfrom
divdavem:proxyViteWebsocket
Jun 15, 2023
Merged

fix: allow using vite as a proxy for another vite server#13218
patak-cat merged 3 commits intovitejs:mainfrom
divdavem:proxyViteWebsocket

Conversation

@divdavem
Copy link
Copy Markdown
Contributor

@divdavem divdavem commented May 16, 2023 •
edited
Loading

Description

The goal of this PR is to allow using vite as a proxy for another vite server, with HMR still working for the upstream server.

Additional context

Currently vite prevents any websocket connection with the vite-hmr websocket protocol from being forwarded to another server. I think it is not correct, vite should only handle itself the connection if it has the correct URL (in addition to the correct websocket protocol), and it should be able forward websocket connections to another server whatever the protocol it uses.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented May 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@divdavem divdavem force-pushed the proxyViteWebsocket branch from 9b2d08f to a32c182 Compare May 16, 2023 15:31
@divdavem divdavem changed the title feat: allow using vite as a proxy for another vite server fix: allow using vite as a proxy for another vite server May 23, 2023
@divdavem divdavem force-pushed the proxyViteWebsocket branch from a32c182 to 44f9370 Compare May 23, 2023 15:46
@divdavem divdavem force-pushed the proxyViteWebsocket branch from 44f9370 to 8887562 Compare May 23, 2023 15:55
@divdavem divdavem marked this pull request as ready for review May 23, 2023 16:07
@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented May 24, 2023

Would you explain your use case? Why is this feature needed in your setup?

@patak-cat patak-cat added the p2-to-be-discussed Enhancement under consideration (priority) label May 24, 2023
@divdavem
Copy link
Copy Markdown
Contributor Author

divdavem commented May 24, 2023 •
edited
Loading

Would you explain your use case? Why is this feature needed in your setup?

The test case that I have included in this PR is basically a very simple reproduction of what we actually do.
We have an application (using vite) that includes multiple applications in iframes. During development, we use the proxy feature of vite in the outer application to include the inner applications at specific paths.
Some of the inner applications use vite, some others don't. One of the inner applications use angular, and the automatic refresh when changing a file works without issue (because the websocket used by the angular cli does not have vite-hmr in the Sec-WebSocket-Protocol header). The automatic refresh of inner applications that use vite do not work in the outer application that use vite. I opened this PR to fix this bug.

@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented May 24, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link
Copy Markdown

vite-ecosystem-ci bot commented May 24, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@patak-cat patak-cat requested a review from sapphi-red June 15, 2023 07:54
sapphi-red
sapphi-red approved these changes Jun 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this is similar with vitejs/vite-plugin-vue#21. But actually this was different from that one.

I think this won't cause any issues for others. 👍

@patak-cat patak-cat enabled auto-merge (squash) June 15, 2023 12:48
@patak-cat patak-cat merged commit 711dd80 into vitejs:main Jun 15, 2023
@divdavem
Copy link
Copy Markdown
Contributor Author

divdavem commented Jun 15, 2023

@sapphi-red @patak-dev Thank you for reviewing and merging my PR!

@bluwy bluwy mentioned this pull request Jul 13, 2023
Closed
4 tasks
@sapphi-red sapphi-red mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

p2-to-be-discussed Enhancement under consideration (priority)

Projects

Team Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@divdavem @patak-cat @sapphi-red