fix(worker): worker import.meta.url should not depends on document in iife mode by sun0day · Pull Request #12629 · vitejs/vite

sun0day · 2023-03-28T10:51:42Z

Description

import.meta.url will be transformed to something like document.currentScript&&document.currentScript.src||new URL("a.js",document.baseURI).href in iife mode. But document is undefined in the worker context.

This PR directly transforms it to new URL('a.js', self.location.href).href

Additional context

What is the purpose of this pull request?

Bug fix
New Feature
Documentation update
Other

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Read the Pull Request Guidelines and follow the PR Title Convention.
Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

…in iife mode

bolt-new-by-stackblitz · 2023-03-28T10:51:45Z

Run & review this pull request in StackBlitz Codeflow.

vinayakkulkarni

LGTM

packages/vite/src/node/plugins/worker.ts

sapphi-red · 2023-04-02T07:42:54Z

packages/vite/src/node/plugins/worker.ts

+    resolveImportMeta(property, { chunkId, format }) {
+      // document is undefined in the worker, so we need to avoid it in iife
+      if (property === 'url' && format === 'iife') {
+        return `new URL('${chunkId}', self.location.href).href`


Suggested change

return `new URL('${chunkId}', self.location.href).href`

return 'self.location.href'

I just noticed that we should use self.location.href here. location.href returns the location of the worker and not the document.
https://developer.mozilla.org/en-US/docs/Web/API/WorkerGlobalScope/location

new URL('${chunkId}', self.location.href).href is be like http://localhost:4173/assets/assets/worker.js which is not correct, because chunkId is like /assets/worker.js and self.location.href is like http://localhost:4173/assets/worker.js.

vinayakkulkarni · 2023-04-02T09:24:50Z

Will this go in 4.2.2 ?

tomayac · 2023-04-19T08:03:18Z

Will this go in 4.2.2 ?

Seems like it didn't make it. I still get…

var de = document.currentScript && document.currentScript.src || new URL("assets/worker-b4ac415f.js",document.baseURI).href;

…in my code. It works fine in dev mode, but not in preview mode. Hoping for the next release.

patak-cat · 2023-04-19T08:07:49Z

@tomayac you can try it out on [email protected]. If no regressions are reported, it will be tagged as 4.3 stable tomorrow.

tomayac · 2023-04-19T08:09:57Z

Oh, amazing! Confirming that it works fine on 4.3.0-beta.8! Thank you <3!

tien · 2023-05-18T00:16:56Z

I'm still getting this issue on 4.3.0-beta.8. Specifically with this dependency @polkadot/api

this line here

export const packageInfo = { name: '@polkadot/x-textdecoder', path: new URL(import.meta.url).pathname, type: 'esm', version: '11.1.3' };

still get compiled to

const yw = {
  name: "@polkadot/x-textdecoder",
  path: {
    url: document.currentScript && document.currentScript.src || new URL("assets/worker-4a3b769e.js",document.baseURI).href
  } && self.location.href ? new URL(self.location.href).pathname.substring(0, new URL(self.location.href).pathname.lastIndexOf("/") + 1) : "auto",
  type: "esm",
  version: "11.1.3"
}

vitejs/vite#12629

patak-cat · 2023-05-18T08:49:33Z

@tien please create a new issue with a minimal reproduction against the latest Vite version (and you can link this PR for reference). A comment on a merged PR doesn't allow us to track your problem properly

vitejs/vite#12629

fix(worker): worker import.meta.url should not depends on document …

69f048b

…in iife mode

sun0day changed the title ~~fix(worker): worker import.meta.url should not depends on document …~~ fix(worker): worker import.meta.url should not depends on document in iife mode Mar 28, 2023

vinayakkulkarni previously approved these changes Mar 28, 2023

View reviewed changes

patak-cat reviewed Mar 29, 2023

View reviewed changes

packages/vite/src/node/plugins/worker.ts Outdated Show resolved Hide resolved

patak-cat dismissed vinayakkulkarni’s stale review via 8a76fec March 29, 2023 19:32

chore: comment wording

8a76fec

patak-cat previously approved these changes Mar 29, 2023

View reviewed changes

sapphi-red reviewed Apr 1, 2023

View reviewed changes

packages/vite/src/node/plugins/worker.ts Outdated Show resolved Hide resolved

refactor: add webWorkerPostPlugin to resolveBuildPlugins

d67aac4

sun0day dismissed patak-cat’s stale review via d67aac4 April 2, 2023 04:41

sapphi-red requested changes Apr 2, 2023

View reviewed changes

fix: use self.location.href

fdf13b2

sapphi-red approved these changes Apr 2, 2023

View reviewed changes

sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: web workers labels Apr 2, 2023

patak-cat merged commit 65f5ed2 into vitejs:main Apr 2, 2023

This was referenced Apr 19, 2023

Import Web Workers with query suffixes break app in production nuxt/nuxt#20191

Closed

Web Workers causes issues in Nuxt 3.1 and above nuxt/nuxt#20361

Closed

tien added a commit to TalismanSociety/talisman-web that referenced this pull request May 18, 2023

fix: web worker accessing undefined document

aea5295

vitejs/vite#12629

tien added a commit to TalismanSociety/talisman-web that referenced this pull request May 18, 2023

fix: web worker accessing undefined document

748da17

vitejs/vite#12629

tien added a commit to TalismanSociety/talisman-web that referenced this pull request May 18, 2023

fix: web worker accessing undefined document

5b5c81e

vitejs/vite#12629

hi-ogawa mentioned this pull request Dec 11, 2023

Abnormal behaviors in building worker modules. #15310

Closed

7 tasks

sapphi-red mentioned this pull request Dec 12, 2023

fix(worker): replace import.meta correctly for IIFE worker #15321

Merged

9 tasks

dragonsea0927 added a commit to dragonsea0927/talisman-web that referenced this pull request Oct 21, 2024

fix: web worker accessing undefined document

a8c53a7

vitejs/vite#12629

mateoBell88 added a commit to mateoBell88/talisman-web that referenced this pull request Sep 15, 2025

fix: web worker accessing undefined document

8107f2d

vitejs/vite#12629

jacobRivera92 added a commit to jacobRivera92/talisman-web that referenced this pull request Sep 17, 2025

fix: web worker accessing undefined document

174e79b

vitejs/vite#12629

scarhug83 added a commit to scarhug83/talisman-web that referenced this pull request Sep 23, 2025

fix: web worker accessing undefined document

decd606

vitejs/vite#12629

aiden94a added a commit to aiden94a/talisman-web that referenced this pull request Sep 25, 2025

fix: web worker accessing undefined document

67ea91c

vitejs/vite#12629

cyber-smith487uo added a commit to cyber-smith487uo/talisman-web that referenced this pull request Sep 29, 2025

fix: web worker accessing undefined document

7775e16

vitejs/vite#12629

spectral-smith987m added a commit to spectral-smith987m/talisman-web that referenced this pull request Oct 23, 2025

fix: web worker accessing undefined document

7092d27

vitejs/vite#12629

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(worker): worker import.meta.url should not depends on document in iife mode#12629

fix(worker): worker import.meta.url should not depends on document in iife mode#12629
patak-cat merged 4 commits intovitejs:mainfrom
sun0day:fix/workerDocument

sun0day commented Mar 28, 2023 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Mar 28, 2023

Uh oh!

vinayakkulkarni left a comment

Uh oh!

Uh oh!

Uh oh!

sapphi-red Apr 2, 2023 •

edited

Loading

Uh oh!

vinayakkulkarni commented Apr 2, 2023

Uh oh!

tomayac commented Apr 19, 2023

Uh oh!

patak-cat commented Apr 19, 2023

Uh oh!

tomayac commented Apr 19, 2023

Uh oh!

tien commented May 18, 2023 •

edited

Loading

Uh oh!

patak-cat commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	return `new URL('${chunkId}', self.location.href).href`
	return 'self.location.href'

Uh oh!

Conversation

sun0day commented Mar 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context

What is the purpose of this pull request?

Before submitting the PR, please make sure you do the following

Uh oh!

bolt-new-by-stackblitz bot commented Mar 28, 2023

Uh oh!

vinayakkulkarni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sapphi-red Apr 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vinayakkulkarni commented Apr 2, 2023

Uh oh!

tomayac commented Apr 19, 2023

Uh oh!

patak-cat commented Apr 19, 2023

Uh oh!

tomayac commented Apr 19, 2023

Uh oh!

tien commented May 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patak-cat commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sun0day commented Mar 28, 2023 •

edited

Loading

sapphi-red Apr 2, 2023 •

edited

Loading

tien commented May 18, 2023 •

edited

Loading