Skip to content

fix(css): use charset: 'utf8' by default for css#12565

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/css-esbuild-charset-utf8
Mar 24, 2023
Merged

fix(css): use charset: 'utf8' by default for css#12565
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/css-esbuild-charset-utf8

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

Description

#10753 changed the default value of charset option passed to esbuild when transforming JS.
This PR changes it for CSS.

Since JS was transformed with charset: 'utf8' already, I think it's fine to change this in a minor.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added has workaround p2-nice-to-have Not breaking anything but nice to have (priority) labels Mar 24, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red changed the title fix: use charset: 'utf8' by default for css fix(css): use charset: 'utf8' by default for css Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has workaround p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants