Run & review this pull request in StackBlitz Codeflow.

I'm not sure about this. I'd prefer if it indexes one char only, when searching longer words I think endsWith or startsWith is the right tool for it.

Did you measure the perf diff on this one @sun0day? I also think that this is going too far. I think we better keep using endsWidth here.

I only tested the js code performance between str.endsWith and str[len-1] === 'x' && str[len-2]==='y', I haven't tested in a real app since I didn't find a proper one.

The thing is that plain === is 60%-70% faster than endsWith in the js perf test. It's really an attractive number. I am not gonna replace all the endsWith in the codebase but replace some hot extensions' judgment.

But also I know that endsWith is not the bottleneck and it may only improve a little perf even if replace all the endsWith in the real app. I am fine with indexing one char only

Thank you for identifying this performance issue. I have reported it to the V8 project.

Thanks @robpalme 🙏🏼

@patak-dev Hi, there, The issue with startsWith and endsWith has been FIXED; I think we need to start using them again! Directly accessing string.length - 1 doesn't seem very good!

@OnlyWick nice! thanks for the heads up, would you like to send a PR to change these?