/ecosystem-ci run

Hmm vite-plugin-ssr seems to be consistently failing with this pr. @brillout maybe you have some ideas why it's happening here. (Note: vite-setup-catalogue is currently failing in main too)

VPS expects all style entries to end with .css, AFAICT rightful so. At least, I certainly don't expect PostCSS files to exist in dist/client/. Therefore I'd argue that all style files should end with .css.

IIUC the output would still be .css. This PR fixes the case when the src in the manifest file points wrongly to, for example, src/style.css instead of src/style.pcss, where the latter is the actual existing file. Is vite-plugin-ssr using the src for something?

VPS doesn't use the src property, so it seems like this PR has some side effects? @faga295

Probably, maybe the assets originName has other uses

@faga295 I would $ diff manifest.json pre/post-PR and see what changes. Chances that you'll see the unwanted side effects right away. (VPS can't find assets post-PR.)

nice~this will help a lot

Seems the originalName of assets chunk only used in generating manifest.json.I really can't think of any other side effects.

@brillout I'm pretty sure this PR doesn't introduce any unwanted change in the manifest, and only changes what's outlined at #12009 (comment). The originalName change in this PR is only used in a few places. I'll run vite-plugin-ssr's test suite again just in case, but this PR looks safe to me.

/ecosystem-ci run vite-plugin-ssr

Looks like it's still failing at https://github.com/brillout/vite-plugin-ssr/blob/e0e96a570a2cc2ded9041fe40d4c68d0a99c7edb/vite-plugin-ssr/node/runtime/renderPage/getPageAssets/getManifestEntry.ts#L44, seems like it's indexing using the manifestKeyMap but this PR makes the index undefined? The getManifestKeyMap doesn't look out of the ordinary to me.

Side effect: brillout/vite-pr-12030-reprod@9e6893d#diff-3b0435c9efe073e8ab8263bbad459657ba8d6826e4a2e5079b67438cb535a466.

The only diff causing this side effect is this PR: brillout/vite-pr-12030-reprod@f0aec13#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519.

(@bluwy FYI brillout@5af52d1.)

Indeed, I debug it and I realized that cssAssetName is not always a cssRequest, such as index.html, so the originalName should be cssFileName instead of cssAssetName

Thanks for helping to check that 🙂 Didn't expect a html file in the CSS plugin. I'll tweak the code a bit and run ecosystem-ci again.

/ecosystem-ci run

📝 Ran ecosystem CI: Open

Seems it still has some problems.

I think we should discuss the standard of the src of manifest.json, because sometimes the ?used query(maybe more other query) will occur in src, I think it's not a expect result.

this is a snapshot of manifest.json built in main branch

the simplest solution of this issue is add .pcss, .postcss, sss based on ispreprocessor, but not include css.