fix: revert "load sourcemaps alongside modules (#11576)"#11775
Merged
patak-dev merged 1 commit intovitejs:mainfrom Jan 20, 2023
Merged
fix: revert "load sourcemaps alongside modules (#11576)"#11775patak-dev merged 1 commit intovitejs:mainfrom
patak-dev merged 1 commit intovitejs:mainfrom
Conversation
…#3288) (vitejs#11576)" This reverts commit dc05e97.
benmccann
changed the title
benmccann
changed the title
patak-dev
approved these changes
Jan 20, 2023
Member
|
Thanks Ben, I agree. @Vap0r1ze let's try again for 4.2, it was good at least to check how it worked in the wild and find out these issues. Thanks! |
|
@patak-dev should we reopen #3288 then ? |
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts #11576 as it's causing failures on the ecosystem CI: #11576 (comment)
Additional context
I'd love to get better source map support added, but source map support is pretty finicky in my experience and the PR being reverted didn't have any tests. We should probably make sure anything source map related has tests and is run against the ecosystem CI before merging on the next attempt. We reverted another attempt at source map support earlier for similar reasons
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).