Skip to content

Comments

fix(ssr): load sourcemaps alongside modules (fix: #3288)#11576

Merged
patak-dev merged 6 commits intovitejs:mainfrom
Vap0r1ze:fix/ssr-sourcemaps
Jan 16, 2023
Merged

fix(ssr): load sourcemaps alongside modules (fix: #3288)#11576
patak-dev merged 6 commits intovitejs:mainfrom
Vap0r1ze:fix/ssr-sourcemaps

Conversation

@Vap0r1ze
Copy link
Contributor

@Vap0r1ze Vap0r1ze commented Jan 3, 2023 •
edited
Loading

Description

Fixes #3288

This PR adds runtime sourcemaps to SSR modules inline.
This isn't a very large change as vite's request transformer provides source maps. The only modification that needed to be made to the source maps was prepending ';;;' to the mappings, as the first three lines of every module will look like this:

async function(a, b, c
) {
'use strict';

Before Changes

image

After Changes

image

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Vap0r1ze
Copy link
Contributor Author

Vap0r1ze commented Jan 4, 2023

It may be worth noting that this also allows me to use breakpoints in VSCode without any debugger; statements

@Vap0r1ze
Copy link
Contributor Author

Vap0r1ze commented Jan 4, 2023

Video of me setting a breakpoint in a TS file in an Astro project with my changes and saving the file (to cause the module to be reloaded)

Code_NCoKzatZOR.mp4

@jere2101
Copy link

jere2101 commented Jan 4, 2023 •
edited
Loading

Just tested it with SvelteKit and it works great (EDIT: for me ;D)🎉
Thank for the fast implementation

@patak-dev
Copy link
Member

patak-dev commented Jan 4, 2023

@manucorporat would you review this one in the context of Qwik?

@jere2101
Copy link

jere2101 commented Jan 4, 2023

Don't know if it helps.

In my test with Qwik debugging worked perfectly fine🤩 but I'm not an Qwik expert.

This was referenced Jan 5, 2023
Open
Closed
@Vap0r1ze
Copy link
Contributor Author

Vap0r1ze commented Jan 10, 2023

@patak-dev is there anything blocking this pr, testing?

sapphi-red
sapphi-red reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
The behavior looks good to me.

@Vap0r1ze Vap0r1ze requested a review from sapphi-red January 12, 2023 00:19
@pasqui23
Copy link

pasqui23 commented Jan 12, 2023 •
edited
Loading

@jere2101 what was the launch.json you used to debug SvelteKit's SSR?

@jere2101
Copy link

jere2101 commented Jan 12, 2023 •
edited
Loading

@jere2101 what was the launch.json you used to debug SvelteKit's SSR?

I tested it without a launch.json. I started npm run dev in the Javascript Debug Terminal of vscode.
Hope this help's you

@Vap0r1ze
Copy link
Contributor Author

Vap0r1ze commented Jan 13, 2023

@sapphi-red I think I've addressed your concerns now

sapphi-red
sapphi-red approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sapphi-red sapphi-red requested a review from patak-dev January 16, 2023 02:14
@patak-dev patak-dev merged commit dc05e97 into vitejs:main Jan 16, 2023
@Vap0r1ze Vap0r1ze deleted the fix/ssr-sourcemaps branch January 16, 2023 06:18
@benmccann
Copy link
Collaborator

benmccann commented Jan 20, 2023

This PR seems to have broken source maps for SvelteKit as SvelteKit's test suite is now failing:

Screenshot from 2023-01-20 06-55-18

I think we should probably revert this PR and add it back only with tests ensuring the source map locations it generates are correct.

benmccann added a commit to benmccann/vite that referenced this pull request Jan 20, 2023
@benmccann
fix: Revert "fix(ssr): load sourcemaps alongside modules (fix: vitejs…
ec1f567 
…#3288) (vitejs#11576)"

This reverts commit dc05e97.
@benmccann benmccann mentioned this pull request Jan 20, 2023
Merged
9 tasks
patak-dev pushed a commit that referenced this pull request Jan 20, 2023
@benmccann
fix: revert "load sourcemaps alongside modules (#11576)" (#11775)
697dd00
sapphi-red pushed a commit to sapphi-red/vite that referenced this pull request Jan 22, 2023
@Vap0r1ze @sapphi-red
fix(ssr): load sourcemaps alongside modules (fix: vitejs#3288) (vitej…
cba0805 
…s#11576)
@sapphi-red sapphi-red mentioned this pull request Jan 22, 2023
Merged
9 tasks
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@Vap0r1ze @futurGH
fix(ssr): load sourcemaps alongside modules (fix: vitejs#3288) (vitej…
7f09694 
…s#11576)
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@benmccann @futurGH
fix: revert "load sourcemaps alongside modules (vitejs#11576)" (vitej…
c21ec1d 
…s#11775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SSR SourceMap not loaded when debugging

7 participants

@Vap0r1ze @jere2101 @patak-dev @pasqui23 @benmccann @Vendicated @sapphi-red