Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be the only option to enable both shortcuts and exiting vite running via
npm-run-allwith default options in onectrl+c.The bad part is that when running vite via
yarnorpnpm, you get an extra error on exit:When using
npm-run-all, it logs:ERROR: "dev" exited with 1.The other option is to not fix the issue. I suggested multiple way to "workaround" the issue: #11434 (comment)
For information, vitest is exiting is code 0 which is subject to the same issue (but probably people don't use vitest watch mode along other watch process)
Re: #11518 #11562