fix: derive useDefineForClassFields value from tsconfig.compilerOptions.target (fixes #10296)#11301
Merged
sapphi-red merged 3 commits intovitejs:mainfrom Dec 11, 2022
Merged
Conversation
sapphi-red
added
the
p4-important
patak-dev
approved these changes
Dec 10, 2022
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
You can merge after resolving the linting issues 👍🏼
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
…tions.target` (fixes vitejs#10296) (vitejs#11301)
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default value of
useDefineForClassFieldsshould be derived fromcompilerOptions.targetinstead oftarget.See #10296 for more details.
fixes #10296
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).