chore(esbuild): add test for configuration overrides#11267
Merged
bluwy merged 4 commits intovitejs:mainfrom Dec 10, 2022
Merged
chore(esbuild): add test for configuration overrides#11267bluwy merged 4 commits intovitejs:mainfrom
bluwy merged 4 commits intovitejs:mainfrom
Conversation
Contributor
Author
|
@sapphi-red let me know if these tests are enough to cover #11049. |
bluwy
approved these changes
Dec 10, 2022
bluwy
changed the title
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests for esbuild plugin, #11049 was merged without these
Additional context
Make sure that specific esbuild options, if specified, correctly override typescript configuration ones.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).